Skip to content

chore(schema-compiler): Make YamlCompiler→renderTemplate() public #9519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

chore(schema-compiler): Make YamlCompiler→renderTemplate() public #9519

merged 1 commit into from
Apr 25, 2025

Conversation

@KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Apr 25, 2025

No description provided.

@codecov
Copy link

codecov bot commented Apr 25, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.02%. Comparing base (d28333a) to head (ecb438e).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...ubejs-schema-compiler/src/compiler/YamlCompiler.ts 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (d28333a) and HEAD (ecb438e). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (d28333a) HEAD (ecb438e)
cubesql 1 0
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #9519       +/-   ##
===========================================
- Coverage   83.86%   59.02%   -24.84%     
===========================================
  Files         230      153       -77     
  Lines       83825    13068    -70757     
  Branches        0     2223     +2223     
===========================================
- Hits        70297     7713    -62584     
+ Misses      13528     5040     -8488     
- Partials        0      315      +315
Flag Coverage Δ
cube-backend 59.02% <0.00%> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon marked this pull request as ready for review April 25, 2025 18:01
@KSDaemon KSDaemon requested a review from a team as a code owner April 25, 2025 18:01
@KSDaemon KSDaemon requested a review from ovr April 25, 2025 18:01
@KSDaemon KSDaemon merged commit 5ad92aa into master Apr 25, 2025
61 checks passed
@KSDaemon KSDaemon deleted the chore/render-refact branch April 25, 2025 19:47
marianore-muttdata pushed a commit to MuttData/cube that referenced this pull request Jun 17, 2025
@KSDaemon @marianore-muttdata
chore(schema-compiler): Make YamlCompiler→renderTemplate() public (cu…
72893ce 
…be-js#9519)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ovr ovr ovr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KSDaemon @ovr